This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
JBIDE-19753 - Investigate if Arquillian works fine with Sapphire 9.0.0 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <import feature="org.eclipse.sapphire.ui.swt.xml.editor" version="8.0.0" match="greaterOrEqual"/> | ||
| <import feature="org.eclipse.sapphire.ui" version="8.0.0" match="greaterOrEqual"/> | ||
| <import feature="org.eclipse.sapphire.ui.swt.gef" version="8.0.0" match="greaterOrEqual"/> | ||
| <import feature="org.eclipse.sapphire" version="9.0.0" match="greaterOrEqual"/> |
There was a problem hiding this comment.
Sapphire changed its API in 9.0.0.201505051659 (included in Mars M7 update site). So any previous 9.0.0.* version (Mars M1-M6) won't work with this PR.
We should require 9.0.0.201505051659 (greaterOrEqual) here in the feature.xml and in all corresponding plugins.xml's.
There was a problem hiding this comment.
I have updated the patch.
| org.eclipse.sapphire.java;bundle-version="0.7.1", | ||
| org.eclipse.sapphire.ui;bundle-version="0.7.1", | ||
| org.eclipse.sapphire.ui.swt.xml.editor;bundle-version="0.7.1", | ||
| org.eclipse.sapphire.platform;bundle-version="9.0.0", |
There was a problem hiding this comment.
I would use 9.0.0.201505051659 in MANIFEST.MF too. It will help avoid problems if the plugin is installed as a dependency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/JBIDE-19753
Investigate if Arquillian works fine with Sapphire 9.0.0