This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
JBIDE-14843 - arquillian validator security concerns #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * http://www.eclipse.org/legal/epl-v10.html | ||
| * | ||
| * Contributors: | ||
| * IBM Corporation - initial API and implementation |
There was a problem hiding this comment.
where is this from originally ?
There was a problem hiding this comment.
This is originally from org.eclipse.ant.internal.core.AntSecurityManager
I have updated the PR.
| } catch (ArquillianSecurityException e) { | ||
| ArquillianCoreActivator.log(e); | ||
| } finally { | ||
| System.setSecurityManager(orig); |
There was a problem hiding this comment.
This is dangerous if for example the AntRunner was run - since they have a securitymanager too.....not sure how to avoid this though.
|
i've applied this since it is better than what we got before which was unprotected, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/JBIDE-14843
arquillian validator security concerns