JBIDE-14564 - Runtime detection prompt shown on every IDE start #108
Conversation
| @@ -119,7 +119,9 @@ private boolean runtimeExists(boolean firstStart, IProgressMonitor monitor) { | |||
| continue; | |||
| } | |||
| monitor.setTaskName(Messages.RuntimeScanner_JBoss_Runtime_Detector_checking + runtimeDefinition.getLocation()); | |||
| return RuntimeUIActivator.runtimeCreated(runtimeDefinition); | |||
| if (!RuntimeUIActivator.runtimeCreated(runtimeDefinition)) { | |||
There was a problem hiding this comment.
I'm not following the change here - you are negating the result here and then negate it when checking.
Isn't the end result the same thing ?
Maybe time for adding a test for this logic?
There was a problem hiding this comment.
No, it isn't. Now, the Search runtime dialog won't be open when there is no one runtime definition.
I have debugged and tested that.
We would probably be able to test the wouldOpenSearchRuntimePathDialog method without adding UI/SWTBoot tests.
There was a problem hiding this comment.
Before this patch, this logic would take the first path which was marked as "scan on every startup" and return whether that runtime was already created. This was bad because it did not support the case of multiple paths, all of which were marked for 'scan on every startup'. In the case of multiple paths, the new logic is correct.
However, for the case of only 1 path to be scanned, the effect of this would appear to be no effect at all.
There was a problem hiding this comment.
However, for the case of only 1 path to be scanned, the effect of this would appear to be no effect at all.?
Try to test just one runtime path that doesn't contains any runtime.
https://issues.jboss.org/browse/JBIDE-14564
Runtime detection prompt shown on every IDE start