Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-16122 maint #215

Merged

Conversation

robstryker
Copy link
Member

Initialization of Download Runtimes wizard is not cancelable.

* It may load plugins or access remote resources.
* Please use the signature with the progress monitor instead
*
* @deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should point at the recommended method call, even if it's obvious here. Same remarks for the rest of deprecated methods

@fbricon
Copy link
Member

fbricon commented Nov 26, 2013

Something's wrong in the stacks retrieval logic. So let's say github is down, we fail at d/l-ing the file, since the stacks client uses the same url, we also skip it : then nothing is returned. BUT the client stacks embeds a stacks yaml so it would need to be returned instead. In order to do that without opening the stacks client jar, we can use something like

StacksClientConfiguration config = new DefaultStacksClientConfiguration();
config.setOnline(false);
StacksClient client = new StacksClient(config, new JBTStacksMessages());

@fbricon
Copy link
Member

fbricon commented Nov 26, 2013

looks fine. +1 after commits are squashed

@robstryker robstryker merged commit 7bab1a8 into jbosstools:jbosstools-4.1.x Nov 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants