New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBIDE-17148 api enhancement for url transport utility class #258

Merged

robstryker merged 1 commit into jbosstools:master from robstryker:JBIDE-17148

Apr 22, 2014

Member

robstryker commented Apr 22, 2014

General structure of the change is that:

A bug was fixed where caches were always incorrect. (String was not url-decoded on load)
Cache indexes have been moved to a standalone index file for each cache
The cached file name now more closely resembles the url it is for, rather than cache-324232432.tmp
A new method signature is added to public API class URLTransportUtility where a cache root can be passed in.


          JBIDE-17148 api enhancement for url transport utility class

ed77687

JBIDE-17148 - method should be private

robstryker merged commit ed77687 into jbosstools:master

fbricon reviewed

View reviewed changes

...ools.foundation.core/src/org/jboss/tools/foundation/core/ecf/internal/URLTransportCache.java

+                             && (numRead=is.read(bytes, offset, bytes.length-offset)) >= 0) {
+                          offset += numRead;
+                      }
+                      is.close();

Member

fbricon Apr 22, 2014

inpuststream isn't closed if is.read throws an exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment