JBIDE-20184 Launching with Java 7 in jbdevstudio.ini results in module… #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +43,9 @@ | |||
| import org.osgi.framework.Constants; | |||
| import org.osgi.service.prefs.BackingStoreException; | |||
|
|
|||
| import com.ibm.icu.text.DateFormat; | |||
There was a problem hiding this comment.
why is it using these from ibm.icu and not plain java versions ?
|
looks "ok" but please add tests for checking it is sane. |
…e errors in subsequent launches with Java 8
|
Rebased and pushed to master. |
| eclipseStartTime = DATE_FORMATTER.parse(str).getTime(); | ||
| } | ||
|
|
||
| private long getEclipseStartTime() { |
There was a problem hiding this comment.
if you made this method protected you could just subclass it in tests to get the time you want and would not need to add a test only setEclipseStartTime method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… errors in subsequent launches with Java 8