JBIDE-21338 - simple npe check when loading credentials model

[robstryker]

targeted to beta2

[fbricon]

+1

[robstryker]

pushed after rebase

[dgolovin]

I now it is too late, but why not this:

...
        credentials = new HashMap<String, String>();
        String usersList = pref.get(PROPERTY_USER_LIST, "");
        if( !usersList.isEmpty()) {
            String[] users = usersList.split("\n");
            for( int i = 0; i < users.length; i++ ) {
                credentials.put(users[i], NOT_LOADED_PASSWORD);
...

no null checks, no extra ternary operator.

[robstryker]

I suppose that would have worked as well, but I prefer to actually know whether the string was null (ie not set) or empty (ie previously persisted as an empty list) so that I can alter behavior based on those two conditions if I need to later. Having the default be the empty string makes me unable to tell the difference between unset and set-as-empty. Anyway, it's already been pushed.