Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-21654 add aeri support for jboss tools #483

Closed
wants to merge 1 commit into from

Conversation

maxandersen
Copy link
Member

DONT MERGE YET - work in progress.

Why:

  • want to get error reports similar to what aeri
    gets for eclipse.org

This change addreses the need by:

  • enabling extension point for aeri in Mars.2

Resolves: JBIDE-21654

@@ -20,7 +20,9 @@ Export-Package: org.jboss.tools.usage.branding,
org.jboss.tools.usage.util.reader
Require-Bundle: org.eclipse.osgi;bundle-version="[3.5.0,4.0.0)",
org.eclipse.core.runtime;bundle-version="[3.5.0,4.0.0)",
org.eclipse.ui;bundle-version="[3.5.0,4.0.0)"
org.eclipse.ui;bundle-version="[3.5.0,4.0.0)",
org.eclipse.epp.logging.aeri.core;bundle-version="1.100.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be optional too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. Fixed.

Why:

 * want to get error reports similar to what aeri
   gets for eclipse.org

This change addreses the need by:

 * enabling extension point for aeri in Mars.2
 * added to usage plugin with optional dependencies
   for biggest impact.

Resolves: JBIDE-21654
@maxandersen
Copy link
Member Author

force updated with fixes for your comments.

@alexeykazakov
Copy link
Contributor

This was merged in the following commits:
3e9b83b
64c3424
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants