JBIDE-21707 NullPointerException in JobResultFuture #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,12 +41,13 @@ public JobResultFuture(Job job) { | |||
|
|
|||
| @Override | |||
| public boolean cancel(boolean mayInterruptIfRunning) { | |||
| if ((isRunning(job) | |||
| && mayInterruptIfRunning) | |||
| || !isRunning(job)) { | |||
There was a problem hiding this comment.
why cancel the job if it's not running?
There was a problem hiding this comment.
It may be still waiting or sleeping. JobManager does all the checks and changes state to NONE. So, even if the current state of job is NONE, it does not harm to call cancel().
For the boolean expression, I only made it a bit shorter, but it is equivalent to what it was.
There was a problem hiding this comment.
State 'sleeping' may mean UI jobs deadlock, the ability to cancel a sleeping job is the true way to salvation.
|
+1 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.