JBIDE-13911 - testUnzipOperationExecuteStringString() always fails on Windows #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +47,7 @@ public void execute(File destination,String filter) throws IOException { | |||
| } | |||
|
|
|||
| public void execute(String destination,String filter) throws IOException { | |||
| execute(new File(destination,filter)); | |||
| execute(new File(destination), filter); | |||
There was a problem hiding this comment.
I'm wondering why this only fails on windows and not other OS's ?
There was a problem hiding this comment.
The test tries to create the "org." directory.
It is a legal UNIX filename, but isn't allowed on Windows. See http://msdn.microsoft.com/en-us/library/aa365247.aspx.
Anyway, the test is invalid because it treats "org." as a filename instead of a filter.
There was a problem hiding this comment.
sounds like more than just this behavior bug needs fixing, the test should be fixed too then?
There was a problem hiding this comment.
The test helped me to find this bug.
After applying this PR, the test and code will work correctly.
|
Pushed to master and 4.1.0.Alpha2x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/JBIDE-13911
org.jboss.tools.common.zip.test.UnzipOperationTest.testUnzipOperationExecuteStringString() always fails on Windows