JBIDE-14298 new extetnsion point to replace previous downloadruntimes #97
Conversation
| * | ||
| * @param map | ||
| */ | ||
| public void loadDownloadableRuntimesFromProviders(Map<String, DownloadRuntime> map) { |
There was a problem hiding this comment.
Have you considered making it package or protected -visible, and make your tests use the same package?
There was a problem hiding this comment.
I intend to make the method private once the full transition is done. At this point, we cannot test through the proper method because the proper method still loads data through 1) the old extension point, and 2) the download xml file on the publicly available website. The proper API is RuntimeExtensionManager.getDownloadRuntimes(), but, as mentioned, it currently is not clean.
Once all transitions and migrations are completed, though, I intend to revert the method to private and have the tests use the proper method for testing.
|
patch is approved if Rob answers the questions. |
|
... and don't forget to squash your commits |
|
merged in to master |
No description provided.