This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
JBIDE-18673 when livereload server is running browsersim/cordovasim should automatically enable livereload #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -446,6 +447,14 @@ private void overrideJsLogFunctions(IBrowser browser) { | |||
| + "})();"); //$NON-NLS-1$ | |||
| } | |||
|
|
|||
| private void enableLivereloadIfAvailable() { | |||
| if (isLivereloadAvailable()) { | |||
There was a problem hiding this comment.
does this not block if livereload is not available ?
There was a problem hiding this comment.
livereload available = server started. So it doesn't blocks anything
There was a problem hiding this comment.
and what if the server is not available - how do we avoid it having to wait for a timeout of the connection ?
There was a problem hiding this comment.
We just "ping" the server, if server is not started - we cannot establish connection(cannot get response code). So everything is OK
…hould automatically enable livereload if livereload server started - livereload enabled on browsersim start
kmarmaliykov
force-pushed
the
JBIDE-18673
branch
from
80efecd
to
74a6910
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if livereload server started - livereload enabled on browsersim start