fix getRemoteFile() to correctly use tmpdir

jbosstools · Mar 9, 2015 · 49b8498 · 49b8498
1 parent 5778a73
commit 49b8498
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/publish/publish.sh b/publish/publish.sh
@@ -40,13 +40,13 @@ getRemoteFile ()
 {
   # requires $wgetParams and $tmpdir to be defined (above)
   getRemoteFileReturn=""
-  URL="$1"
-  output=`mktemp getRemoteFile.XXXXXX`
-  if [[ ! `wget ${wgetParams} ${URL} -O ${tmpdir}/${output} 2>&1 | egrep "ERROR 404"` ]]; then # file downloaded
-    getRemoteFileReturn=${tmpdir}/${output}
+  grfURL="$1"
+  output=`mktemp --tmpdir=${tmpdir} getRemoteFile.XXXXXX`
+  if [[ ! `wget ${wgetParams} ${grfURL} -O ${output} 2>&1 | egrep "ERROR 404"` ]]; then # file downloaded
+    getRemoteFileReturn=${output}
   else
     getRemoteFileReturn=""
-    rm -f ${tmpdir}/${output}
+    rm -f ${output}
   fi
 }