JBDS-3495 add Docker plugins (not feature) to... ... JBT site to avoid p2.inf config instruction #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f config instruction org.eclipse.linuxtools.docker.core depends on com.spotify.docker.client (JBDS-3495)
nickboldt
force-pushed
the
JBDS-3495_2
branch
from
15ecf4e
to
fb490ad
Compare
| @@ -284,10 +284,20 @@ | |||
| <category name="CoreTools" /> | |||
| <category name="MavenTools"/> | |||
| </feature> | |||
| <feature id="org.eclipse.linuxtools.docker.feature"> | |||
| <!-- JBDS-3495 add plugins instead of feature to avoid p2.inf instruction which forces JBDS to include Docker nightly update site in disabled state --> | |||
There was a problem hiding this comment.
why is this change necessary when we removed the p2.inf instructions ?
There was a problem hiding this comment.
Because removing them from the update site doesn't remove them from the feature itself. My previous solution was incomplete and full o' fail. This one actually works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.