[JBIDE-17281] Use build/pluginManagement instead of build/plugins #143
Conversation
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.eclipse.tycho</groupId> | ||
| <artifactId>tycho-packaging-plugin</artifactId> | ||
| <version>${tychoVersion}</version> | ||
| <configuration> | ||
| <format>'${BUILD_ALIAS}-v'yyyyMMdd-HHmm</format> |
There was a problem hiding this comment.
File is now 30 lines longer and contains multiple tycho-packaging-plugin entries. Why is this better?
|
I share the same concerns as @nickboldt . IMO, that change doesn't make things easier to maintain and does not fix any issue. |
|
Now I grok this. This will mean we can remove stuff like https://github.com/jbosstools/jbosstools-server/blob/master/as/tests/org.jboss.tools.as.test.core/pom.xml#L25 since the version used for the plugins will now be defined in the parent pom. This is actually a recommended best practice for maven. |
|
Another year goes by with nothing done here. I'm inclined to reject this. See https://issues.jboss.org/browse/JBIDE-17281?focusedCommentId=13132910&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13132910 |
|
closed as out of date. |
No description provided.