Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-13329 SDK-less Targets #37

Closed
wants to merge 1 commit into from
Closed

JBIDE-13329 SDK-less Targets #37

wants to merge 1 commit into from

Conversation

mickaelistria
Copy link
Contributor

@nickboldt
Copy link
Member

Should not remove sdkbundle as jbt gwt stuff requires it. Could include the plugin if you want to omit the feature, I suppose.

** [1] ./plugins/org.jboss.tools.gwt.core/META-INF/MANIFEST.MF **
9- org.jboss.tools.common;bundle-version="[3.2.0,4.0.0)",
10- com.google.gwt.eclipse.core,
11: com.google.gwt.eclipse.sdkbundle;bundle-version="[2.4.0,3.0.0)",
12- com.google.gdt.eclipse.suite;bundle-version="3.0.1",
13- org.eclipse.core.runtime;bundle-version="[3.5.0,4.0.0)",

** [2] ./plugins/org.jboss.tools.gwt.core/src/org/jboss/tools/gwt/core/IGoogleEclipsePluginConstants.java **
57- public static final String WELCOME_FILE = "Gwt_jboss.html"; //$NON-NLS-1$
58-
59: public static final String GWT_SDK_BUNDLENAME = "com.google.gwt.eclipse.sdkbundle"; //$NON-NLS-1$
60-
61- public static final String GWT_SERVLET_NAME = "gwt-servlet.jar"; //$NON-NLS-1$

@nickboldt
Copy link
Member

Should these changes be applied against the 40x branch instead of master? I would expect master to include a TP for 4.3.0.M4, not 4.2.0/4.2.1.

@mickaelistria
Copy link
Contributor Author

On 01/10/2013 08:50 PM, Nick Boldt wrote:

Should these changes be applied against the 40x branch instead of
master? I would expect master to include a TP for 4.3.0.M4, not
4.2.0/4.2.1.

If we want to make some changes for 4.2.0 and 4.2.1, it will create a
4.2.0.d and 4.2.1.b TP, as proposed in the PR. So in any case, it won't

break previous builds.

Mickael Istria
Eclipse developer at JBoss, by Red Hat http://www.jboss.org/tools
My blog http://mickaelistria.wordpress.com - My Tweets
http://twitter.com/mickaelistria

@nickboldt
Copy link
Member

Well, regardless, com.google.gwt.eclipse.sdkbundle is still required. Can you talk to @andre about why he requires the sdkbundle plugin?

@nickboldt
Copy link
Member

Further thought occurs to me... we need multiple versions of the publish.sh script for 4.0 and 4.1 streams. Or the script has to know about 4.2.0., 4.2.1. and 4.3.0.M4 for JBT and JBDS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants