Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-13954 - Can't target runtime in archetypes wizard #100

Closed
wants to merge 1 commit into from

Conversation

snjeza
Copy link
Member

@snjeza snjeza commented Apr 17, 2013

https://issues.jboss.org/browse/JBIDE-13954
Can't target runtime in archetypes wizard

@snjeza
Copy link
Member Author

snjeza commented Apr 18, 2013

Why was it commented? Shouldn't we just remove it?

I am not sure if Fred intend to add something there because there is the following comment:

//TODO read facet version from project example metadata

I have removed the commented code.

Fix should actually search for compatible target runtimes instead of replacing search with list of all available target runtimes.

That functionality will be included in https://issues.jboss.org/browse/JBIDE-14085

@dgolovin
Copy link
Member

why not just use constant version "3.0" and then fix JBIDE-14085, it has all the benefits:

  1. It works the same way as previous version and would not let select any target runtime;
  2. Changes are minimal.

@fbricon
Copy link
Member

fbricon commented Apr 19, 2013

I agree with @dgolovin
I applied commit a7bfa4f which currently locks the facet to 3.0, until JBIDE-14085 is fixed

@fbricon fbricon closed this Apr 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants