JBIDE-14548 fix IAE while installing plugins via project examples requirements #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| environment.put( | ||
| "org.jboss.tools.central.version.minor", version.getMinor()); //$NON-NLS-1$ | ||
| environment.put( | ||
| "org.jboss.tools.central.version.micro", version.getMicro()); //$NON-NLS-1$ |
There was a problem hiding this comment.
if this is removed what is the purpose of the method ?
There was a problem hiding this comment.
returns a map containing system.properties. But that could indeed be moved to https://github.com/jbosstools/jbosstools-central/pull/122/files#L14R55
…uirements - Moved mylyn discovery from central to project-examples - refactored 3 ConnectorDiscovery creation points into one DiscoveryUtil method Author: Denis Golovin <dgolovin@gmail.com> CoAuthor: Fred Bricon <fbricon@gmail.com>
| @@ -1230,21 +1230,6 @@ private void logIgnoredExtensionPoint(IExtension extension) { | |||
| log(builder.toString()); | |||
| } | |||
|
|
|||
| public static Dictionary<Object, Object> getEnvironment() { | |||
|
+1 for the code going in based on review, but I haven't had time to try/verify it at runtime so please test that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method
Author: Denis Golovin dgolovin@gmail.com
CoAuthor: Fred Bricon fbricon@gmail.com