JBIDE-17496 JBIDE-17504: Prevent from parallel loading of same repo #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| installButton.setEnabled(true); | ||
| } | ||
| JBossDiscoveryUi.install(toInstall, dialog); | ||
| } catch (Exception ex) { |
There was a problem hiding this comment.
should be
} catch (InterruptedException ex) {
JBossCentralActivator.getDefault().getLog().log(new Status(IStatus.ERROR, JBossCentralActivator.ID, ex.getMessage(), ex));
} catch (InvocationTargetException ite) {
JBossCentralActivator.getDefault().getLog().log(new Status(IStatus.ERROR, JBossCentralActivator.ID, ite.getMessage(), ite));
}There was a problem hiding this comment.
also in CheckForUpdatesAction.run() method in the end of the class Exception should be changed to org.eclipse.core.commands.common.CommandException.
There was a problem hiding this comment.
I amended the commit to apply your suggestions.
This is a workaround to avoid p2 bug 436378
|
merged in master and beta2. However, I kept the part where the installbutton was disabled during install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to avoid p2 bug 436378