JBIDE-17808: Mechanism to define and detect "families" of IU #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| point="org.eclipse.ui.installationPages"> | ||
| <page | ||
| class="org.jboss.tools.central.installation.EarlyAccessInstallationPage" | ||
| id="org.jboss.tools.central.installtion.earlyaccessPage" |
There was a problem hiding this comment.
installtion is not spelled correctly.
|
I pushed an amended version of the commit that applies the various suggestions you've made. |
| <extension | ||
| point="org.eclipse.ui.installationPages"> | ||
| <page | ||
| class="org.jboss.tools.central.installation.EarlyAccessInstallationPage" |
There was a problem hiding this comment.
Lets call this page CentralInstallationPage since it will be more than earlyaccess
|
if you do those tiny label renames for the about install box I'm +1 to get this in. the mechanism is sound and we can extend it over time. |
* Plugins can contribute a "family" definition (such as earlyaccess, supported, blacklisted...) which lists the various ius for the given family * A utility class allows to do request to compare current installation with families * Central editor shows when Early Access content is installed (computed from family) * An installation page is added to report Early Access IUs
|
PR updated:
|
|
Note that I don't have the power to merge this change. So @dgolovin or @maxandersen , I let you take care of it when you're ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supported,
blacklisted...) which lists the various ius for the given family
with families
from family)