JBIDE-18214: Add missing bundle #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,4 +29,6 @@ | |||
| <import feature="org.jboss.tools.runtime.seam.detector.feature" version="3.4.0" match="greaterOrEqual"/> | |||
| </requires> | |||
|
|
|||
| <plugin id="org.jboss.tools.community.central" download-size="0" install-size="0" version="0.0.0" unpack="false"/> | |||
There was a problem hiding this comment.
i wonder why this have'nt been needed before ?
There was a problem hiding this comment.
Actually, this bundles contained nothing before.
It was the location were the JBoss Tools theme was integrated before we removed it. Since theme was removed, bundle was removed too.
However, now, with the earlyaccess listing, we have yet another use-case of a JBT or JBDS sepecific customization, so we need to revive such a bundle.
There was a problem hiding this comment.
okey, and where is the corresponding configuration on the jbds side ?
There was a problem hiding this comment.
It's in com.jbds.devstudio.core.central, cf jbdevstudio/jbdevstudio-product@c7cc260
|
Looks reasonable, +1. |
|
Applied in master and 4.2.x branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.