JBIDE-18247 : delay remote variable resolution to when necessary #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When displaying Central, ProxyWizardManager and RefreshBuzzJob instantiations trigger fetching of remote resources (ide-config.property), that could block the UI for an indefinite amount of time. The values being looked up are not required until later, by methods running in Jobs, so the current fix consists in performing the lookups only when necessary and when it's safe to do it. The fix is certainly not ideal, other parts of the code calling PropertiesHelper.getPropertiesProvider().getValue(...) might require better handling as well, but this would require major refactoring at the foundation level (introducing/handling timeouts). Until a better redesign can be performed, the current fix makes Central not blocking the UI, as expected. Some jobs keeps running for a very long time in the background but they can be cancelled any time. Signed-off-by: Fred Bricon <fbricon@gmail.com>
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying Central, ProxyWizardManager and RefreshBuzzJob instantiations trigger fetching of remote resources (ide-config.properties), that could block the UI for an indefinite amount of time.
The values being looked up are not required until later, by methods running in Jobs, so the current fix consists in performing the lookups only when necessary and when it's safe to do it.
The fix is certainly not ideal, other parts of the code calling PropertiesHelper.getPropertiesProvider().getValue(...) might require better handling as well, but this would require major refactoring at the foundation level (introducing/handling timeouts).
Until a better redesign can be performed, the current fix makes Central not blocking the UI, as expected. Some jobs keeps running for a very long time in the background but they can be cancelled any time.
Signed-off-by: Fred Bricon fbricon@gmail.com