JBIDE-18277: Update earlyaccess listing #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this even stored in git, since it's updated via mvn on each build? |
|
That's a good point. I could remove the file if you prefer. |
|
Yup, I think removing the file + updating .gitignore will require less maintenance |
|
Actually, this file is currently not in repo. I thought it was in and required an update, but since it's not it and it's already fetched at each build, there is nothing to update here. |
|
if it's not in the repo, how does git see it as modified then? :-) |
Listing is fetched at build time
|
Ok, I pushed a commit removing the file and adding it to ,gitignore. |
|
@fbricon : If you're ok with it, please merge it to jbosstools-4.2.x and cherry-pick it to master. |
|
applied on both branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.