[JBIDE-18920] NullPointerException in "Check installation for Early Access" #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about we throw a new type of (checked?) exception if software installation is not supported. Would be caught in the UI layer, where an error message would be displayed |
|
Sounds good to me :) What would be the message? "Current Eclipse instance doesn't support software installation.". WDYT? |
|
+1 |
dgolovin
force-pushed
the
JBIDE-18920-M
branch
from
198f752
to
3c28f90
Compare
…ccess" Fix contains changes to prevent NPE when running from development environment without enabling software installation support.
dgolovin
force-pushed
the
JBIDE-18920-M
branch
from
3c28f90
to
d9e82bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix contains changes to prevent NPE when running from development
environment without enabling software installation support.