[JBIDE-19292] Closing Central right after JBDS startup SWTException #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix moves update code in UI thread and releave editor from finding current display. UIJob will find current display for running workspace and call runInUIThred method inside runnable passed to display.asyncExec() metyhod. updateTitle() method itself safe to run when Central editor is closed, because it has all isDisposed() checks for involved wigets.
|
Applied in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix moves update code in UI thread and relive editor from
finding current display. UIJob will find current display
for running workspace and call runInUIThred method inside
runnable passed to display.asyncExec() method. updateTitle()
method itself is safe to run when Central editor is closed, because
it has all isDisposed() checks for involved widgets.