JBIDE-19410: Avoid pop-up (show error on UI and in log instead) #328
Conversation
| HeaderText.this.hasEarlyAccessIUs = InstallationChecker.getInstance().hasEarlyAccess(); | ||
| public IStatus run(IProgressMonitor monitor) { | ||
| try { | ||
| HeaderText.this.installChecker = InstallationChecker.getInstance(); |
There was a problem hiding this comment.
you prolly want to check HeaderText is not disposed
There was a problem hiding this comment.
This line doesn't do anything related to UI, so there is no point in checking whether it's disposed or not.
There was a problem hiding this comment.
UIJob here is required, because updateTitle(heading) requires display.
There was a problem hiding this comment.
You're right. I don't get how I could miss this issue...
See amended commit. However, I prefer running as few things as possible in UIThread since it creates UI freezes and slowness. I prefered encapsulating the UI changes in a Display.exec().
|
@fbricon What's still blocking to merge that? |
| } catch (ProvisionException ex) { | ||
| JBossCentralActivator.log(ex); | ||
| } | ||
| heading.getDisplay().syncExec(new Runnable() { |
There was a problem hiding this comment.
heading.getDisplay() will failed if disposed
|
Change was amended to fix the last issue you've spotted. |
|
applied in master |
No description provided.