Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-20100: Better integration of EA in user workflow #354

Closed
wants to merge 1 commit into from
Closed

JBIDE-20100: Better integration of EA in user workflow #354

wants to merge 1 commit into from

Conversation

mickaelistria
Copy link
Contributor

No description provided.

@maxandersen
Copy link
Member

what does "better" mean here? would be great if the commit message actually outlined the change(s) being made.

@mickaelistria
Copy link
Contributor Author

Basically, it's just "Show EA connectors by default". Would it be OK?

@maxandersen
Copy link
Member

show EA connectors by default breaks the logic of what is in EA (i.e. angularjs exist in both) so I don't think that can be the only thing you did here ?

@mickaelistria
Copy link
Contributor Author

What I did is explained in the Jira, however, I cannot make it fit in 80 characters, The core part of the contributions is that users can see EA content without having to having to enable anything. Everything else is adapting current UI and workflows to this approach.

@maxandersen
Copy link
Member

80 characters ? git commit messages can be multi-lined.

The jira talks about 3 to 4 different ways and currently mainly focused about the About dialog so was not sure what this commit is covering.

@mickaelistria
Copy link
Contributor Author

It's covering everything ;) I'll put more details in the commit message.

@mickaelistria
Copy link
Contributor Author

More description added to commit message.

@alexeykazakov
Copy link
Contributor

@mickaelistria could you please attache (here or to JIRA) a screencast video or a bunch of screenshots how, for example, AngularJS installation will look like with this PR applied?

@mickaelistria
Copy link
Contributor Author

Quick demo of how users are now facing Early-Access: https://vid.me/qPQz
For the part about installation page, which is open when hitting "Manage Early-Access", please see screenshots on related Jira ticket.

@alexeykazakov
Copy link
Contributor

I like the idea how multiple versions IUs are handled but shouldn't we add descriptions of all the options (not just titles/names) to that dialog when you are selecting the regular/EA versions?

@mickaelistria
Copy link
Contributor Author

Yes, ideally, I'd like to reuse the UI as it is shown on the Software/updates page. This is more a 1st increment to show/validate the workflow.
Do you prefer that we 1st merge it and then work on improving the choice dialog, or we merge it right now (to avoid potential divergence and to give a change to other people to work on it) and will add improvements as following commits?

@alexeykazakov
Copy link
Contributor

Installation from central is a critical part of JBT/JBDS. And we are approaching CR1/GA release. I would like to see a complete PR with at least @maxandersen's and @fbricon's approval before we push anything to master.

* Early Access connectors are shown by default (when no other version
exists)
* When connector exists in regular and EA version, show regular version,
then ask user at install which one they actually want to install
* Move control and overview on Early Access to an installation page,
accessible from Software/Update page
@mickaelistria
Copy link
Contributor Author

The PR was updated to show same UI in selection pop-up (when relevant) than in the discovery viewer.
It also removes the uninstall of EA content when disabling EA (both are separated).

@fbricon
Copy link
Member

fbricon commented Sep 8, 2015

Applied in master

@fbricon fbricon closed this Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants