New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JBIDE-17002 add new Patch connector for Java 8 support in PDE/JDT/m2e/WTP >> jbosstools-4.1.x #151
Conversation
…found a wiki or blog that mentions more than just JDK 8 + JDT + Kepler, and this connector handles PDE and m2e, plus WTP
<!-- Patches --> | ||
|
||
<connectorCategory | ||
description="Patches" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need a patches catatgory ? can't this just be in the development tools category ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, a Java 8 category or under Maven would work too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the related Jira, I also suggest creation of a Java 8 category which would contain splitted features.
I guess since more people are looking at the Jira, it's better to keep the discussion there.
<iu id="org.eclipse.jdt.java8patch"/> | ||
<iu id="org.eclipse.jst.common.fproj.enablement.jdt.feature.patch"/> | ||
<iu id="org.eclipse.m2e.feature"/> | ||
<iu id="org.eclipse.m2e.logback.feature"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't we say logback and m2e.sdk should not be listed ?
@fbricon ^
I merged Nick's commits in a single one and pushed it on jbosstools-4.1.x branch: eab76de |
just so I dont have to check again - @mickaelistria merged this commit but removed the m2e.logback and sdk as agreed. |
No description provided.