Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-19691 fix descriptions of angularjs-eclipse-feature connectors in Central and EA >> master #278

Merged
merged 1 commit into from Apr 23, 2015

Conversation

nickboldt
Copy link
Member

No description provided.

@@ -59,7 +59,7 @@ reasonable, reporting issues to these providers as required.</description>
categoryId="org.jboss.tools.central.discovery.a.web"
groupId="org.jboss.tools.central.discovery.a.web.core"
certificationId="com.jboss.jbds.discovery.certification.supported"
description="AngularJS Tooling support for Ionic framework"
description="AngularJS Tooling provides content assist and navigation + Ionic framework support"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only EA connector provides navigation. It comes from Eclipse AngularJS plugin (available in EA only). JBT/JBDS provides only AngularJS content assist + ionic support.
So this description should be the same as for jbosstools/org.jboss.tools.central.discovery/plugin.xml:
"AngularJS Tooling provides content assist + Ionic framework support"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I must have copied & pasted from the wrong plugin.xml -- they all looked the same until you pointed out that having tern in the EA version mean the addition of "navigation" in the description. Fixed and force pushed.

Better?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Just a minor thing... I would use "Ionic" instead of "ionic" in all four connectors.

…in Central and EA

JBIDE-19691 fix com.jboss.jbds.central.discovery - should not mention it provides navigation (that's only in EA)

fix case of ionic -> Ionic
@nickboldt nickboldt merged commit a3b3751 into jbosstools:master Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants