JBIDE-18413: Refreshing CheckboxTableControlBuilder choices when value choices change #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fbricon can you review this PR? Thanks |
| Iterable<Object> defaultValues = selectMany.getValue(); | ||
| if (defaultValues != null) { | ||
| for (Object object : defaultValues) { | ||
| data.add(converter.convert(object)); |
There was a problem hiding this comment.
can the converter return null values?
There was a problem hiding this comment.
No, only if object is null. But nevertheless I'll add a check here
|
@fbricon I applied your suggested fixes. Please review this PR again |
| Iterable<Object> valueChoices = selectMany.getValueChoices(); | ||
| if (valueChoices == null) | ||
| return; | ||
| List<String> newItems = new ArrayList<String>(); |
There was a problem hiding this comment.
if you can, assign the expected size directly. But that's me nitpicking
There was a problem hiding this comment.
The expected size of what exactly?
There was a problem hiding this comment.
of newItems. Can we know the size of selectMany without iterating it?
There was a problem hiding this comment.
nope, it's an Iterable
|
+1 to apply |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.