Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBIDE-21791: Prompt user to save open current open editor before executing command #157

Merged
merged 1 commit into from Mar 10, 2016

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Mar 8, 2016

@fbricon @maxandersen @alexeykazakov can someone review this?

@gastaldi gastaldi changed the title JBIDE-21791: Current editor is now saved when the command menu is invoked JBIDE-21791: Prompt user to save open current open editor before executing command Mar 8, 2016
@gastaldi
Copy link
Contributor Author

gastaldi commented Mar 8, 2016

Confirmation dialog:
screenshot from 2016-03-08 19-47-10

Preferences Page:
screenshot from 2016-03-08 19-45-19

@maxandersen
Copy link
Member

Looks good (just looking at UI)

Suggestion for reword: "(For Forge to access latest changes you need to save)"

…uting command

This change introduces a new preference option in the Forge preference page.
@gastaldi
Copy link
Contributor Author

Done, thanks for the rewording hint

@gastaldi gastaldi merged commit 9cfd60d into jbosstools:jbosstools-4.3.x Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants