FUSETOOLS-2564 - WSDL 2 Camel Rest DSL Wizard #1138

bfitzpat · 2017-10-11T21:03:42Z

This is the first cut of the wsdl2rest code. The tests run after the jars are populated (mvn generate-sources) and the wizard attempts to run, but there's an issue with the wizard perform finish where it's not quite getting as far as the tests are. I suspect it has something to do with a classloader issue, but am still investigating.

VERY PRELIMINARY WORK

bfitzpat · 2017-10-18T20:33:24Z

Can now run the wsdl2rest utility code through the wizard. Working on updating the wizard to improve that experience next.

apupier

very quick overview.

I find it hard to know what you have to modify from original codebase to have ti working, if we can have the "core" functionality in a separate repo I think that it will really help for reviewing and understanding it
I tried to put feedback only on few things that will surely stay here in the future and that can already be improved

apupier · 2017-10-25T15:00:48Z

...r/plugins/org.fusesource.ide.wsdl2rest.ui/src/org/fusesource/ide/wsdl2rest/ui/Activator.java

@@ -0,0 +1,50 @@
+package org.fusesource.ide.wsdl2rest.ui;


missing header

apupier · 2017-10-25T15:01:16Z

....fusesource.ide.wsdl2rest.ui/src/org/fusesource/ide/wsdl2rest/ui/wizard/Wsdl2RestWizard.java

+		try {
+			generate(new URL(page.getWsdlURL()), page.getOutputPathURL());
+		} catch (Exception e) {
+			// do something with this


return false and log error ?

apupier · 2017-10-25T15:02:47Z

...e.ide.wsdl2rest.ui/src/org/fusesource/ide/wsdl2rest/ui/wizard/pages/Wsdl2RestWizardPage.java

+	private String beanClass;
+
+	public Wsdl2RestWizardPage(String pageName) {
+		super(pageName);


what about calling this(pageName, null, null) to avoid duplicating the setMessage ?

apupier · 2017-10-25T15:03:53Z

...e.ide.wsdl2rest.ui/src/org/fusesource/ide/wsdl2rest/ui/wizard/pages/Wsdl2RestWizardPage.java

+				}
+			}
+		} catch (JavaModelException e) {
+			e.printStackTrace();


don't forget to use logger instead of printStackTrace

apupier · 2017-10-25T16:01:42Z

editor/plugins/org.fusesource.ide.wsdl2rest/src/org/jboss/fuse/wsdl2rest/ClassGenerator.java

@@ -0,0 +1,9 @@
+package org.jboss.fuse.wsdl2rest;


missing header

bfitzpat · 2017-10-25T22:16:31Z

Thanks for the feedback @apupier . I will add a readme file to help folks get some context on how to test this and will work through all of your suggestions. That said, this is merely a prototype branch and not meant to be the end-all-and-be-all, so until we figure out what we're doing with the core wsdl2rest code I am going to avoid splitting it out just yet.

lhein · 2017-12-08T07:29:20Z

...ource.ide.wsdl2rest.ui/src/org/fusesource/ide/wsdl2rest/ui/internal/i18n/messages.properties

@@ -0,0 +1,31 @@
+# Copyright (c) 2017 Red Hat, Inc.


shouldn't the path be .../l10n/messages.properties?

apupier

few pure code feedback

apupier · 2017-12-08T07:47:50Z

editor/plugins/org.fusesource.ide.wsdl2rest.ui/META-INF/MANIFEST.MF

+Bundle-ManifestVersion: 2
+Bundle-Name: wsdl2rest UI plug-in
+Bundle-SymbolicName: org.fusesource.ide.wsdl2rest.ui;singleton:=true
+Bundle-Version: 10.1.0.qualifier


we are now on 10.2

apupier · 2017-12-08T07:48:35Z

editor/plugins/org.fusesource.ide.wsdl2rest.ui/pom.xml

+	<parent>
+		<groupId>org.fusesource.ide.editor</groupId>
+		<artifactId>plugins</artifactId>
+		<version>10.1.0-SNAPSHOT</version>


we are now on 10.2

apupier · 2017-12-08T07:51:26Z

editor/plugins/org.fusesource.ide.wsdl2rest.ui/pom.xml

+		<dependency>
+			<groupId>commons-validator</groupId>
+			<artifactId>commons-validator</artifactId>
+			<version>1.4.0</version>


Optional: latest version is 1.6.0 https://commons.apache.org/proper/commons-validator/ in case it is possible to upgrade, it might be a good idea to start with latest version.
I'm wondering if we shouldn't try to ask Jboss tools to provide an osgi version of it in the Target Platform

1.6.0 doesn't seem to be available in our maven repos currently, but this would be good to investigate

they are using 1.6 version: https://mvnrepository.com/artifact/commons-validator/commons-validator/1.6
2 additional notes:

I guess it needs to be updated in wsdl to rest first

it would be even best if we can provide an orbit bundle to avoid embedding the lib in the plugin

apupier · 2017-12-08T07:52:36Z

editor/plugins/org.fusesource.ide.wsdl2rest.ui/pom.xml

+				<artifactId>maven-enforcer-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>ban-uberjars</id>


Do you know from where this rule comes from? it is from Jboss tools? if yes, it might give more importantce to have the commons-validator available in Target Platform.

This was copied from the switchyard plug-ins (org.switchyard.tools.cxf was the model I used for the wsdl2rest code wrapper). Not sure we need it. Will investigate removing it when I start migrating to pulling wsdl2rest as a maven artifact instead of building a one-off copy of the code directly.

apupier · 2017-12-08T07:53:07Z

...org.fusesource.ide.wsdl2rest.ui/src/org/fusesource/ide/wsdl2rest/ui/internal/UIMessages.java

@@ -0,0 +1,50 @@
+/******************************************************************************* 
+ * Copyright (c) 2015 Red Hat, Inc. 


apupier · 2017-12-08T08:05:20Z

...e.wsdl2rest.ui/src/org/fusesource/ide/wsdl2rest/ui/wizard/pages/Wsdl2RestWizardBasePage.java

+				};
+			}
+		};
+		dialog.setInitialPattern("* "); //$NON-NLS-1$


why '* ' and not '*'? (with a space after the asterisk)

apupier · 2017-12-08T08:06:30Z

....wsdl2rest.ui/src/org/fusesource/ide/wsdl2rest/ui/wizard/pages/Wsdl2RestWizardFirstPage.java

+		}
+
+		setControl(composite);
+        setPageComplete(isPageComplete());


indentation issue

apupier · 2017-12-08T08:07:18Z

...wsdl2rest.ui/src/org/fusesource/ide/wsdl2rest/ui/wizard/pages/Wsdl2RestWizardSecondPage.java

+		}
+
+		setControl(composite);
+        setPageComplete(isPageComplete());


indentation issue

apupier · 2017-12-08T08:08:37Z

...wsdl2rest.ui/src/org/fusesource/ide/wsdl2rest/ui/wizard/pages/Wsdl2RestWizardSecondPage.java

+		ControlDecorationSupport.create(beanClassBinding, SWT.LEFT | SWT.TOP);
+
+		// set initial values
+		if (!Strings.isEmpty(getOptionsFromWizard().getDestinationJava())) {


what do you think to extract a little method such as:

public void initIfNotEmpty (Text textControl, String value) { if (!Strings.isEmpty(value)) { textControl.setText(value); } }

it will allow to write:

initIfNotEmpty(javaPathTextControl, getOptionsFromWizard().getDestinationJava()); initIfNotEmpty(camelPathTextControl, getOptionsFromWizard().getDestinationCamel()); initIfNotEmpty(targetAddressText, getOptionsFromWizard().getTargetServiceAddress()); initIfNotEmpty(beanClassText, getOptionsFromWizard().getBeanClassName());

apupier · 2017-12-08T08:14:16Z

editor/plugins/org.fusesource.ide.wsdl2rest/META-INF/MANIFEST.MF

+Bundle-ManifestVersion: 2
+Bundle-Name: Wsdl2rest
+Bundle-SymbolicName: org.fusesource.ide.wsdl2rest
+Bundle-Version: 10.1.0.qualifier


apupier · 2017-12-11T10:17:34Z

...ugins/org.fusesource.ide.wsdl2rest/src/org/jboss/fuse/wsdl2rest/impl/ResourceMapperImpl.java

+    }
+
+    private boolean resourceExists(String resource) {
+        for (String str : this.resources) {


I think that resources.contains(resource); can be used

We will be pulling this code in jarred form from maven, so I won't change it at this time, but a good spot.

I created a PR upstream jboss-fuse/wsdl2rest#34

apupier · 2017-12-11T10:18:00Z

...ugins/org.fusesource.ide.wsdl2rest/src/org/jboss/fuse/wsdl2rest/impl/ResourceMapperImpl.java

@@ -0,0 +1,128 @@
+package org.jboss.fuse.wsdl2rest.impl;


missing header

We will be pulling this code in jarred form from maven, so I won't change it at this time, but a good spot.

bfitzpat · 2017-12-12T13:46:57Z

testPR

bfitzpat · 2017-12-12T17:09:15Z

Neither of the failing tests has anything to do with my code. Any ideas @lhein or @apupier ? Just errant errors popping up randomly?

bfitzpat · 2017-12-12T20:23:54Z

testPR

bfitzpat · 2017-12-15T15:01:28Z

testPR

apupier

done a new pure code review. I will review functionally later.

apupier · 2017-12-12T08:37:39Z

core/tests/org.fusesource.ide.camel.model.tests/.project

@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8"?>


this project is not existing anymore, isn't it?

see bfitzpat#25

apupier · 2017-12-12T08:39:22Z

editor/plugins/org.fusesource.ide.wsdl2rest.ui/readme.md

+This plug-in provides a wizard wrapper for the Wsdl2Rest code originally found here: [https://github.com/jboss-fuse/wsdl2rest](https://github.com/jboss-fuse/wsdl2rest)
+
+## Running the wizard
+NOTE: THIS DOES NOT WORK CURRENTLY, BUT DEMONSTRATES THE BASIC APPROACH.


don't forget to remove this line

apupier · 2017-12-12T08:41:20Z

editor/plugins/org.fusesource.ide.wsdl2rest.ui/readme.md

+On the "Specify Advanced Options for wsdl2rest Processing", click the "..." beside the Bean Class field and select the EchoServiceImpl class. 
+Click Finish.
+
+Select the project and refresh it to see the generated code and new rest-camel-context.xml file. 


shouldn't we say "the generated code and the new rest-camel-context.xml file."?
But I'm not the native speaker, just checking that it has not be forgotten (and if you can explain me what is the rule for that if i'm wrong it will help me to improve my English skill)

I say "...to see the generated code and new rest-camel-context.xml file." The second "the" you included is implied because it's a simple list of two items. You could certainly include it, but it's not necessary.

apupier · 2017-12-12T08:42:35Z

editor/plugins/org.fusesource.ide.wsdl2rest.ui/readme.md

+    <dependency>
+      <groupId>org.apache.camel</groupId>
+      <artifactId>camel-jackson</artifactId>
+      <version>2.20.0</version>


currently the wsdl-to-rest project is based on Camel 2.18.0, does it have an impact?

Is it worthy to put 2.20.1 now that it is released?

apupier · 2017-12-12T08:43:44Z

editor/plugins/org.fusesource.ide.wsdl2rest.ui/readme.md

+
+The generated echo.Echo class will have many errors due to some missing dependencies.
+
+Add the following dependencies to your project pom.xml:


Why do we need to add these dependencies? it is just because of the particular use case or it will be always?
If always, can you create a task to add it automatically please?

Created https://issues.jboss.org/browse/FUSETOOLS-2869

apupier · 2017-12-26T14:42:51Z

editor/plugins/org.fusesource.ide.wsdl2rest/pom.xml

+
+  <artifactId>org.fusesource.ide.wsdl2rest</artifactId>
+  <packaging>eclipse-plugin</packaging>
+  <name>JBoss Fuse Tooling :: Camel Editor :: Plugins :: Wsdl2Rest Implemenatation </name>


typo Implemenatation -> Implementation

apupier · 2017-12-26T14:43:44Z

editor/plugins/org.fusesource.ide.wsdl2rest/pom.xml

+        <version.junit>4.11</version.junit>
+        <version.wsdl4j>1.6.3</version.wsdl4j>
+        <version.commons.lang>2.4</version.commons.lang>
+        <version.wsdl2rest>0.7-SNAPSHOT</version.wsdl2rest>


this version will be changed when a (productized?) release will be available, right?

Hope so, yes.

apupier · 2017-12-26T14:45:08Z

...ource.ide.wsdl2rest.tests/src/org/jboss/fuse/wsdl2rest/test/doclit/CamelCxfWsDocLitTest.java

+
+public class CamelCxfWsDocLitTest {
+
+//    @Test


completely commented out test class, Should we remove it or uncomment it?

Removed whole test plugin

apupier · 2017-12-26T14:45:56Z

...ource.ide.wsdl2rest.tests/src/org/jboss/fuse/wsdl2rest/test/rpclit/CamelCxfWsRpcLitTest.java

+
+public class CamelCxfWsRpcLitTest {
+
+//    @Test


completely commented out test class, shoudl we remove it or uncomment it?

Removed whole test plugin

apupier · 2017-12-26T14:46:55Z

...esource.ide.wsdl2rest.tests/src/org/jboss/fuse/wsdl2rest/test/rpclit/GenerateRpcLitTest.java

+        Assert.assertEquals(5, methods.size());
+    }
+
+//    @Test


is this commented out test relevant?
if yes, can you remove it please
If no, can you enable it please

Removed whole test plugin

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

if needed Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

bfitzpat · 2018-04-23T19:15:21Z

Last commit adds better validation to the path fields (adding a warning if the path doesn't exist yet and can be created or an error if there's no way to create it, which shouldn't be the case) and adds the camel path if it needs to.

I still think there should be a way to introspect the camel project and get the actual location (i.e. different between springboot, spring, and blueprint projects) and we could just use that to avoid having to create the folder.

apupier · 2018-04-24T08:27:24Z

test is failing on CI:

java.lang.AssertionError: 
Expecting:
 <false>
to be equal to:
 <true>
but was not.
	at org.fusesource.ide.wsdl2rest.ui.tests.integration.Wsdl2RestWizardIT.testWsdl2RestWizardFinish(Wsdl2RestWizardIT.java:61)

apupier · 2018-04-24T08:28:30Z

I still think there should be a way to introspect the camel project and get the actual location (i.e. different between springboot, spring, and blueprint projects) and we could just use that to avoid having to create the folder.

maybe we can start by having a different path for springboot/spring/blueprint which are matching the templates that we are providing in Tooling?
There is also a property in the pom.xml which is specifying the path to the camel context in case it i not the "default one"; For org.apache.camel:camel-maven-plugin -> configuration -> fileApplicationContextUri but seems more complicated I would raise it as a future possible enhancement

apupier · 2018-04-24T08:33:32Z

After really testing that File Dialog, I'm not liking having to go outside Eclipse to find a WSDL path. We're tossing them to the root of the file system now vs. looking for a WSDL file in the project that they're looking to generate inside.

it is going to the default path registered on the OS.
It is also possible to set an initial path, we can put the currently selected project for instance.

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

bfitzpat · 2018-04-24T16:20:18Z

Do we have a utility to discover if a project is Springboot vs. Spring vs. Blueprint?

* removed duplicated "find resource" method and streamlined * added new tests to ensure Blueprint path is working * improved FuseProject class with better Blueprint support Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

…into FUSETOOLS-2564

bfitzpat · 2018-04-26T14:02:19Z

In the process of work on making sure we're not overwriting files, it became clear that a bit more clean-up needed to happen.

removed duplicated "find resource" method and streamlined
added new tests to ensure Blueprint path is working
improved FuseProject class with better Blueprint support

apupier

there is still a case where the user can loose/override data without warning, it is if he clicks finish on the first page of the wizard as the warning is displayed only on the second page
the warning is not displayed in my case:
-- I generated a first time
-- I'm trying to generate a second time on the same project with same wsdl

but maybe this modification that you show me in mattermost are not pushed yet?

apupier · 2018-04-27T08:05:12Z

editor/plugins/org.fusesource.ide.wsdl2rest.ui/META-INF/MANIFEST.MF

@@ -13,7 +13,7 @@ Require-Bundle: org.eclipse.ui,
 org.eclipse.core.databinding,
 org.jboss.tools.foundation.core,
 org.jboss.tools.foundation.ui,
- org.fusesource.ide.foundation.core,
+ org.fusesource.ide.foundation.core;visibility:=reexport,


better to always avoid to "reexport", if another plugin needs the dependencies, it should declare the dependencies in its MANIFEST too

apupier · 2018-04-27T08:24:58Z

Do we have a utility to discover if a project is Springboot vs. Spring vs. Blueprint?

Not exactly
There is org.fusesource.ide.camel.editor.utils.MavenUtils.isSyndesisExtensionProject(IProject) which might make sense to factorize code with.
There are org.fusesource.ide.foundation.core.util.CamelUtils.isBlueprintFile(String) and org.fusesource.ide.foundation.core.util.CamelUtils.isSpringFile(String) to detect File type
there are org.fusesource.ide.camel.model.service.core.util.CamelCatalogUtils.hasSpringBootDependency(List)
org.fusesource.ide.launcher.run.util.MavenLaunchUtils.isSpringBootProject(IFile)

surely some code to reuse/factorize :-)

apupier · 2018-04-27T08:27:43Z

some tests are failing, I guess due to modification of the FuseProject rule:

bfitzpat · 2018-04-27T14:13:02Z

Thanks for the hints as to springboot detection.

And damn. Sorry about the FuseProject change. I'll see what I can figure out and get working again.

* Finish is disabled if overwrite state could happen for Java files or for the Camel configuration * User now has the possibility to specify a specific camel file name for the generated config in the field * Also added support for Springboot projects so we get the path for generated camel files correct * Added new test for custom camel file in path Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

…into FUSETOOLS-2564

bfitzpat · 2018-04-30T13:15:34Z

I believe I have fixed the issue with FuseProject - it doesn't fail locally now in those Red deer tests

rhdevelopers-ci · 2018-04-30T15:11:36Z

SonarQube analysis reported 9 issues

9 critical

Watch the comments in this conversation to review them.

7 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

FuseProject.java#L50: Define a constant instead of duplicating this literal " \n" 4 times.
FuseProject.java#L53: Define a constant instead of duplicating this literal " \n" 4 times.
FuseProject.java#L56: Define a constant instead of duplicating this literal " \n" 4 times.
FuseProject.java#L57: Define a constant instead of duplicating this literal " \n" 4 times.
FuseProject.java#L68: Define a constant instead of duplicating this literal " \n" 3 times.
FuseProject.java#L69: Define a constant instead of duplicating this literal " org.apache.camel\n" 3 times.
FuseProject.java#L72: Define a constant instead of duplicating this literal " \n" 3 times.

lhein · 2018-05-02T05:32:00Z

I am not even able to build the branch. See https://gist.github.com/lhein/a72250fd3bf5d2e78cd870a9cc06baa6

lhein · 2018-05-02T07:46:04Z

also this PR is not rebased with latest master and still on version 10.x

bfitzpat · 2018-05-09T15:35:57Z

This one is now obsolete. We are going with #1362

bfitzpat · 2018-05-09T15:37:35Z

Can close once we merge the other PR

bfitzpat added the DRAFT label Oct 11, 2017

lhein added the NEW FEATURE label Oct 12, 2017

lhein changed the title ~~Fusetools 2564 - initial wsdl2rest code~~ FUSETOOLS-2564 - initial wsdl2rest code Oct 12, 2017

lhein changed the title ~~FUSETOOLS-2564 - initial wsdl2rest code~~ FUSETOOLS-2564 - WSDL 2 Camel Rest DSL Wizard Oct 12, 2017

apupier reviewed Oct 25, 2017

View reviewed changes

bfitzpat force-pushed the FUSETOOLS-2564 branch from be145a5 to d861439 Compare October 26, 2017 12:36

bfitzpat force-pushed the FUSETOOLS-2564 branch from 7fbe6f1 to 170d8e0 Compare December 8, 2017 00:05

lhein reviewed Dec 8, 2017

View reviewed changes

apupier requested changes Dec 11, 2017

View reviewed changes

apupier reviewed Dec 11, 2017

View reviewed changes

bfitzpat force-pushed the FUSETOOLS-2564 branch from 89c4e11 to c5cd2ab Compare December 13, 2017 00:23

apupier requested changes Dec 26, 2017

View reviewed changes

lhein added the DO NOT MERGE label Jan 16, 2018

apupier removed the DO NOT MERGE label Jan 29, 2018

bfitzpat added 9 commits March 13, 2018 10:43

Initial stab at wrapping wsdl2rest code

6ef2349

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

Initial Wizard contribution

d9d95c7

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

Next round of updates.

04418a4

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

Can successfully run the wsdl2rest code from the wizard and tests now

fdcb728

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

Added ability to provide more detail via the wizard page

0d4aaf6

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

A few more updates

a6148b6

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

Refactoring one-page into two-page wizard with validation

2e5788c

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

Cleanup and externalization of strings

60e5d1f

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

Correcting i10n issues

ba40549

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

FUSETOOLS-2564 - fixing path validation and creating camel path

6fc6c3f

if needed Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

FUSETOOLS-2564 - fixing camel path problem and refactoring test

22e32b4

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

bfitzpat added 2 commits April 26, 2018 07:59

FUSETOOLS-2564 - a few improvements and new tests

5fdc183

* removed duplicated "find resource" method and streamlined * added new tests to ensure Blueprint path is working * improved FuseProject class with better Blueprint support Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

Merge branch 'master' of https://github.com/jbosstools/jbosstools-fuse …

82bcf72

…into FUSETOOLS-2564

apupier requested changes Apr 27, 2018

View reviewed changes

bfitzpat added 3 commits April 27, 2018 13:17

FUSETOOLS-2564 - fixed FuseProject

d7caeff

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

Merge branch 'master' of https://github.com/jbosstools/jbosstools-fuse …

857dd2c

…into FUSETOOLS-2564

bfitzpat added the READY FOR REVIEW label Apr 30, 2018

bfitzpat added DO NOT MERGE Obsolete and removed NEW FEATURE READY FOR REVIEW labels May 9, 2018

apupier mentioned this pull request May 14, 2018

Fusetools 2564 - Wsdl to rest wizard #1362

Merged

13 tasks

bfitzpat closed this May 17, 2018

		@@ -0,0 +1,50 @@
		/*******************************************************************************
		* Copyright (c) 2015 Red Hat, Inc.


		The generated echo.Echo class will have many errors due to some missing dependencies.

		Add the following dependencies to your project pom.xml:

FUSETOOLS-2564 - WSDL 2 Camel Rest DSL Wizard #1138

FUSETOOLS-2564 - WSDL 2 Camel Rest DSL Wizard #1138

Conversation

bfitzpat commented Oct 11, 2017

bfitzpat commented Oct 18, 2017

apupier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bfitzpat commented Oct 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apupier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bfitzpat commented Dec 12, 2017

bfitzpat commented Dec 12, 2017

bfitzpat commented Dec 12, 2017

bfitzpat commented Dec 15, 2017

apupier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bfitzpat commented Apr 23, 2018

apupier commented Apr 24, 2018

apupier commented Apr 24, 2018 • edited

apupier commented Apr 24, 2018

bfitzpat commented Apr 24, 2018

bfitzpat commented Apr 26, 2018

apupier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

apupier commented Apr 27, 2018

apupier commented Apr 27, 2018

bfitzpat commented Apr 27, 2018

bfitzpat commented Apr 30, 2018

rhdevelopers-ci commented Apr 30, 2018

7 extra issues

lhein commented May 2, 2018

lhein commented May 2, 2018

bfitzpat commented May 9, 2018

bfitzpat commented May 9, 2018

apupier commented Apr 24, 2018 •

edited