FUSETOOLS-3007 - New UI test for Forge projects #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
reviewed
Jul 24, 2018
| @@ -0,0 +1,52 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2017 Red Hat, Inc. | |||
| @@ -0,0 +1,184 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2017 Red Hat, Inc. | |||
| view.setConsoleText(option.getNumber() + CMD_RETURN); | ||
| } | ||
| } | ||
| AbstractWait.sleep(TimePeriod.SHORT); |
There was a problem hiding this comment.
why do you need a wait.sleep? There is a waituntil just after
|
|
||
| private void checkCamelEditor(String projectName) { | ||
| for (Resource res : new ProjectExplorer().getProject(projectName).getChildren()) { | ||
| if (res.getText().equals("Camel Contexts")) { |
There was a problem hiding this comment.
better to invert equals to avoid potential NPEs
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { |
There was a problem hiding this comment.
why do you need to override hashCode and equals method?
djelinek
reviewed
Jul 24, 2018
| ForgeConsoleView view = new ForgeConsoleView(); | ||
| view.open(); | ||
| createProject(project); | ||
| if (LogChecker.noFuseError()) { |
There was a problem hiding this comment.
LogChecker.noFuseErrors() returns "true" if there aren't "fuse" errors in error log, maybe did you expecting opposite here ?
djelinek
reviewed
Jul 24, 2018
| new CamelProject(PROJECT_NAME).update(); | ||
| } | ||
| checkCamelEditor(PROJECT_NAME); | ||
| collector.checkThat("Project contains some errors", LogChecker.noFuseError(), equalTo(true)); |
https://issues.jboss.org/browse/FUSETOOLS-3007 (You can create a Fuse Integration Projects via JBoss Forge) Signed-off-by: Tomáš Sedmík <tsedmik@redhat.com>
djelinek
approved these changes
Jul 25, 2018
|
testPR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/FUSETOOLS-3007
(You can create a Fuse Integration Projects via JBoss Forge)
Signed-off-by: Tomáš Sedmík tsedmik@redhat.com
Pull Request Checklist
After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.
General
Functional
Maintainability
Tests
Legal