Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fusetools 3189 java11 compatibility2 attempt with all in same bundle #1512

Conversation

apupier
Copy link
Member

@apupier apupier commented Mar 14, 2019

Pull Request Checklist

After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.

General

  • Did you use the Jira Issue number in the commit comments?
  • Did you set meaningful commit comments on each commit?
  • Did you sign off all commits for this PR? (git commit -s -m "jira issue number - your commit comment")

Functional

  • Did the CI job report a successful build?
  • Is the non-happy path working, too?

Maintainability

  • Are all Sonar reported issues fixed or can they be ignored?
  • Is there no duplicated code?
  • Are method-/class-/variable-names meaningful?

Tests

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Do we need a new UI test?

Legal

  • Have you used the correct file header copyright comment?
  • Have you used the correct year in the headers of new files?

@apupier apupier requested review from a team as code owners March 14, 2019 10:35
@apupier
Copy link
Member Author

apupier commented Mar 14, 2019

#1511 to be reviewed and merged before

- put all in same bundle as:
-- a different version of jaxb (core/impl/api/xjc) is required different
than the one provided by jbosstools.common.jaxb
-- apache servicemix doesn't provide a bundle for this newer version
-- due to some split packages, seems cannot provide it in a different
bundle (even if there should surely be a way to do it)
-- also needs to provide javax.ws
- set xsd external access to all for xsd when launching wsdl2rest
transformation. Same workaround applied than for Data Transformation

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier force-pushed the FUSETOOLS-3189-Java11Compatibility2-attemptWithAllInSameBundle branch from 781ef1e to 52e8234 Compare March 14, 2019 13:17
@apupier
Copy link
Member Author

apupier commented Mar 14, 2019

wsdl2rest tests passed with Java 11 job https://fusesource-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Fuse%20Tooling/job/jbosstools-fuse_master-jdk11/lastCompletedBuild/testReport/

Copy link
Contributor

@bfitzpat bfitzpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with successful tests! great work!

@apupier
Copy link
Member Author

apupier commented Mar 15, 2019

created https://issues.jboss.org/browse/FUSETOOLS-3194 for follow-up, improving design to help for future maintenance

@djelinek
Copy link
Contributor

UI tests with java 8 seems to be ok

@apupier apupier merged commit c6afd0d into jbosstools:master Mar 15, 2019
@apupier apupier deleted the FUSETOOLS-3189-Java11Compatibility2-attemptWithAllInSameBundle branch March 15, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants