Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUSETOOLS-3291 - workaround missing m2e support for Syndesis #1586

Merged

Conversation

apupier
Copy link
Member

@apupier apupier commented Nov 7, 2019

extension-maven-plugin

it was available in older versions.

Signed-off-by: Aurélien Pupier apupier@redhat.com

Pull Request Checklist

After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.

General

  • Did you use the Jira Issue number in the commit comments?
  • Did you set meaningful commit comments on each commit?
  • Did you sign off all commits for this PR? (git commit -s -m "jira issue number - your commit comment")

Functional

  • Did the CI job report a successful build?
  • Is the non-happy path working, too?

Maintainability

  • Are all Sonar reported issues fixed or can they be ignored?
  • Is there no duplicated code?
  • Are method-/class-/variable-names meaningful?

Tests

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Do we need a new UI test?

Legal

  • Have you used the correct file header copyright comment?
  • Have you used the correct year in the headers of new files?

extension-maven-plugin

it was available in older versions.

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier requested a review from a team as a code owner November 7, 2019 09:45
@apupier
Copy link
Member Author

apupier commented Nov 7, 2019

tests that can check for that are disabled due to unsupported Maven 3.6.1+ by Syndesis Maven plugin

@apupier
Copy link
Member Author

apupier commented Nov 8, 2019

Templates build failing due to upstream issue https://issues.jboss.org/browse/ENTESB-12223

@apupier apupier merged commit d41dd45 into jbosstools:master Nov 14, 2019
@apupier apupier deleted the FUSETOOLS-3285-WorkaroundBadMavenPlugin branch November 14, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants