Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUSETOOLS2-49 - Add sonar.organization to default #1587

Merged
merged 1 commit into from Nov 14, 2019

Conversation

apupier
Copy link
Member

@apupier apupier commented Nov 7, 2019

Since we are one of the early adopters of SonarCloud, our project still
belongs to the "Attic" organization - which was originally the only
organization on SonarCloud when the service started. Because of this,
until now, we did not have to specify the "sonar.organization" property
on our project since it was defaulting to the "Attic" org. For
consistency reasons, SonarSource are going to make this property
mandatory, which means that we have to set it to "default".

Signed-off-by: Aurélien Pupier apupier@redhat.com

Pull Request Checklist

After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.

General

  • Did you use the Jira Issue number in the commit comments?
  • Did you set meaningful commit comments on each commit?
  • Did you sign off all commits for this PR? (git commit -s -m "jira issue number - your commit comment")

Functional

  • Did the CI job report a successful build?
  • Is the non-happy path working, too?

Maintainability

  • Are all Sonar reported issues fixed or can they be ignored?
  • Is there no duplicated code?
  • Are method-/class-/variable-names meaningful?

Tests

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Do we need a new UI test?

Legal

  • Have you used the correct file header copyright comment?
  • Have you used the correct year in the headers of new files?

Since we are one of the early adopters of SonarCloud, our project still
belongs to the "Attic" organization - which was originally the only
organization on SonarCloud when the service started. Because of this,
until now, we did not have to specify the "sonar.organization" property
on our project since it was defaulting to the "Attic" org. For
consistency reasons, SonarSource are going to make this property
mandatory, which means that we have to set it to "default".

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier requested a review from a team as a code owner November 7, 2019 10:19
Copy link
Contributor

@bfitzpat bfitzpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 when we have a green build again

@apupier
Copy link
Member Author

apupier commented Nov 8, 2019

Templates build failing due to upstream issue https://issues.jboss.org/browse/ENTESB-12223

@apupier apupier merged commit 34817f4 into jbosstools:master Nov 14, 2019
@apupier apupier deleted the FUSETOOLS2-49-SonarOrganization branch November 14, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants