Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FUSETOOLS-3320: Fix regex inside UI Tests to avoid failures on JDK11 #1601

Merged
merged 1 commit into from Apr 7, 2020
Merged

FUSETOOLS-3320: Fix regex inside UI Tests to avoid failures on JDK11 #1601

merged 1 commit into from Apr 7, 2020

Conversation

djelinek
Copy link
Contributor

Signed-off-by: Dominik Jelinek djelinek@redhat.com

Pull Request Checklist

After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.

General

  • Did you use the Jira Issue number in the commit comments?
  • Did you set meaningful commit comments on each commit?
  • Did you sign off all commits for this PR? (git commit -s -m "jira issue number - your commit comment")

Functional

  • Did the CI job report a successful build?
  • Is the non-happy path working, too?

Maintainability

  • Are all Sonar reported issues fixed or can they be ignored?
  • Is there no duplicated code?
  • Are method-/class-/variable-names meaningful?

Tests

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Do we need a new UI test?

Legal

  • Have you used the correct file header copyright comment?
  • Have you used the correct year in the headers of new files?

@djelinek djelinek requested a review from a team as a code owner March 16, 2020 18:34
tsedmik
tsedmik previously approved these changes Mar 17, 2020
View reviewed changes
@djelinek
Copy link
Contributor Author

testPR

@djelinek
FUSETOOLS-3320: Fix regex inside UI Tests to avoid failures on JDK11
d1bb882 
Signed-off-by: Dominik Jelinek <djelinek@redhat.com>
@djelinek
Copy link
Contributor Author

djelinek commented Apr 2, 2020

testPR

@djelinek djelinek requested a review from tsedmik April 2, 2020 13:48
@djelinek djelinek merged commit eb94740 into jbosstools:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsedmik tsedmik tsedmik approved these changes

Assignees
No one assigned
Labels
REVIEW DONE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djelinek @tsedmik