Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FUSETOOLS-3332 - remove unused import package in test class #1603

Merged
merged 1 commit into from Apr 1, 2020
Merged

FUSETOOLS-3332 - remove unused import package in test class #1603

merged 1 commit into from Apr 1, 2020

Conversation

apupier
Copy link
Member

@apupier apupier commented Mar 26, 2020

Pull Request Checklist

After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.

General

  • Did you use the Jira Issue number in the commit comments?
  • Did you set meaningful commit comments on each commit?
  • Did you sign off all commits for this PR? (git commit -s -m "jira issue number - your commit comment")

Functional

  • Did the CI job report a successful build?
  • Is the non-happy path working, too?

Maintainability

  • Are all Sonar reported issues fixed or can they be ignored?
  • Is there no duplicated code?
  • Are method-/class-/variable-names meaningful?

Tests

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Do we need a new UI test?

Legal

  • Have you used the correct file header copyright comment?
  • Have you used the correct year in the headers of new files?

@apupier apupier requested a review from a team as a code owner March 26, 2020 14:15
@apupier apupier added the DRAFT label Mar 26, 2020
@apupier apupier force-pushed the FUSETOOLS-3332-CBRJavaFalseValidationError branch 2 times, most recently from c2f6ef7 to 14ec111 Compare March 30, 2020 13:42
@apupier
FUSETOOLS2-3332 - remove import not needed in test class
9575443 
given that the same package is used between the test class and the used
class, the import package is not needed.
Starting with Eclipse 2020-03, this case is reported as a warning
"unused import package"

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier force-pushed the FUSETOOLS-3332-CBRJavaFalseValidationError branch from d1a0ecf to 9575443 Compare April 1, 2020 07:37
@apupier apupier changed the title WIP dummy modif to have a PR build FUSETOOLS-3332 - remove unused import package in test class Apr 1, 2020
@apupier apupier removed the DRAFT label Apr 1, 2020
@apupier apupier mentioned this pull request Apr 1, 2020
Merged
@apupier apupier added the PRIO label Apr 1, 2020
@apupier
Copy link
Member Author

apupier commented Apr 1, 2020

setting PRIo label as it is to fix tests that are failign on master

@apupier apupier merged commit 3ec8caa into jbosstools:master Apr 1, 2020
@apupier apupier deleted the FUSETOOLS-3332-CBRJavaFalseValidationError branch April 1, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhein lhein lhein approved these changes

Assignees
No one assigned
Labels
PRIO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apupier @lhein