Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUSETOOLS-3331 - reactivate tests as webkit 2 is now availabel on CI #1605

Merged
merged 1 commit into from Apr 9, 2020

Conversation

apupier
Copy link
Member

@apupier apupier commented Mar 30, 2020

Signed-off-by: Aurélien Pupier apupier@redhat.com

Pull Request Checklist

After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.

General

  • Did you use the Jira Issue number in the commit comments?
  • Did you set meaningful commit comments on each commit?
  • Did you sign off all commits for this PR? (git commit -s -m "jira issue number - your commit comment")

Functional

  • Did the CI job report a successful build?
  • Is the non-happy path working, too?

Maintainability

  • Are all Sonar reported issues fixed or can they be ignored?
  • Is there no duplicated code?
  • Are method-/class-/variable-names meaningful?

Tests

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Do we need a new UI test?

Legal

  • Have you used the correct file header copyright comment?
  • Have you used the correct year in the headers of new files?

@apupier apupier requested a review from a team as a code owner March 30, 2020 09:45
@bfitzpat
Copy link
Contributor

No luck with this one?

@apupier
Copy link
Member Author

apupier commented Mar 31, 2020

No luck with this one?

Seems there are some other package that are missing.
Will need to setup a RHEL 7.7 instance and see what are the exact requirements to have it working.
Jboss Tools QE were able to make it working but they have a lot of dependencies and they don't know which are the mandatory ones

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier force-pushed the FUSETOOLS-331-reactivatetests branch from 87dc52e to dcdfb30 Compare April 7, 2020 08:40
@apupier
Copy link
Member Author

apupier commented Apr 8, 2020

build in success. The Jenkins slaves now contain "@server with GUI" group packages.

Copy link
Contributor

@lhein lhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@apupier apupier merged commit 6dade94 into jbosstools:master Apr 9, 2020
@apupier apupier deleted the FUSETOOLS-331-reactivatetests branch April 9, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants