Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUSETOOLS-3330 - provide a camel catalog cache bundle for Camel 2.21.… #1608

Merged
merged 2 commits into from Apr 7, 2020

Conversation

lhein
Copy link
Contributor

@lhein lhein commented Mar 31, 2020

…0.fuse-760027-redhat-00001

Signed-off-by: Lars Heinemann lhein.smx@gmail.com

Pull Request Checklist

After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.

General

  • Did you use the Jira Issue number in the commit comments?
  • Did you set meaningful commit comments on each commit?
  • Did you sign off all commits for this PR? (git commit -s -m "jira issue number - your commit comment")

Functional

  • Did the CI job report a successful build?
  • Is the non-happy path working, too?

Maintainability

  • Are all Sonar reported issues fixed or can they be ignored?
  • Is there no duplicated code?
  • Are method-/class-/variable-names meaningful?

Tests

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Do we need a new UI test?

Legal

  • Have you used the correct file header copyright comment?
  • Have you used the correct year in the headers of new files?

@lhein lhein requested a review from a team as a code owner March 31, 2020 14:47
bfitzpat
bfitzpat previously approved these changes Mar 31, 2020
Copy link
Contributor

@bfitzpat bfitzpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if we get a mostly green build

lhein and others added 2 commits April 6, 2020 10:10
…0.fuse-760027-redhat-00001

Signed-off-by: Lars Heinemann <lhein.smx@gmail.com>
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Copy link
Member

apupier commented Apr 6, 2020

will do the rebase

@apupier apupier merged commit ac924a5 into jbosstools:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants