Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FUSETOOLS-3480: Move JDK8 logic into utils and reuse in all relevant … #1697

Merged
merged 1 commit into from Jul 22, 2021
Merged

FUSETOOLS-3480: Move JDK8 logic into utils and reuse in all relevant … #1697

merged 1 commit into from Jul 22, 2021

Conversation

pospisilf
Copy link
Contributor

…UI tests

Pull Request Checklist

After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.

General

  • Did you use the Jira Issue number in the commit comments?
  • Did you set meaningful commit comments on each commit?
  • Did you sign off all commits for this PR? (git commit -s -m "jira issue number - your commit comment")

Functional

  • Did the CI job report a successful build?
  • Is the non-happy path working, too?

Maintainability

  • Are all Sonar reported issues fixed or can they be ignored?
  • Is there no duplicated code?
  • Are method-/class-/variable-names meaningful?

Tests

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Do we need a new UI test?

Legal

  • Have you used the correct file header copyright comment?
  • Have you used the correct year in the headers of new files?

@pospisilf pospisilf requested a review from a team as a code owner June 16, 2021 10:17
@djelinek djelinek mentioned this pull request Jun 16, 2021
Merged
13 tasks
@djelinek
Copy link
Contributor

testPR

@apupier
Copy link
Member

apupier commented Jun 18, 2021

need to rebase on master to have green build on both PR jobs

@pospisilf pospisilf requested a review from tsedmik June 22, 2021 19:42
@pospisilf
Copy link
Contributor Author

rebased and signed off

apupier
apupier reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have separated the code related to JDK8

2 comments seems incorrect/improvable

...s/plugins/org.jboss.tools.fuse.reddeer/src/org/jboss/tools/fuse/reddeer/utils/JDK8Check.java Outdated Show resolved Hide resolved
...s/plugins/org.jboss.tools.fuse.reddeer/src/org/jboss/tools/fuse/reddeer/utils/JDK8Check.java Outdated Show resolved Hide resolved
@pospisilf
FUSETOOLS-3480: Move JDK8 logic into utils and reuse in all relevant …
d200db8 
…UI tests

Signed-off-by: Filip Pospisil <fpospisi@redhat.com>
@pospisilf
Copy link
Contributor Author

Both comments hopefully improved.

@djelinek djelinek removed the request for review from tsedmik June 29, 2021 14:45
@djelinek
Copy link
Contributor

testPR

4 similar comments
@djelinek
Copy link
Contributor

testPR

@djelinek
Copy link
Contributor

testPR

@djelinek
Copy link
Contributor

testPR

@djelinek
Copy link
Contributor

testPR

@djelinek djelinek merged commit b3a72c3 into jbosstools:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apupier apupier apupier approved these changes

@djelinek djelinek djelinek approved these changes

Assignees
No one assigned
Labels
READY FOR MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pospisilf @djelinek @apupier