Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FUSETOOLS-2500: UI Tests - Provide new UI test for choices properties… #1698

Merged
merged 1 commit into from Aug 2, 2021
Merged

FUSETOOLS-2500: UI Tests - Provide new UI test for choices properties… #1698

merged 1 commit into from Aug 2, 2021

Conversation

pospisilf
Copy link
Contributor

… drop-down

Pull Request Checklist

After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.

General

  • Did you use the Jira Issue number in the commit comments?
  • Did you set meaningful commit comments on each commit?
  • Did you sign off all commits for this PR? (git commit -s -m "jira issue number - your commit comment")

Functional

  • Did the CI job report a successful build?
  • Is the non-happy path working, too?

Maintainability

  • Are all Sonar reported issues fixed or can they be ignored?
  • Is there no duplicated code?
  • Are method-/class-/variable-names meaningful?

Tests

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Do we need a new UI test?

Legal

  • Have you used the correct file header copyright comment?
  • Have you used the correct year in the headers of new files?

@pospisilf pospisilf requested a review from a team as a code owner June 24, 2021 21:27
@pospisilf
FUSETOOLS-2500: UI Tests - Provide new UI test for choices properties…
c8e26ef 
… drop-down

Signed-off-by: Filip Pospisil <fpospisi@redhat.com>
@djelinek djelinek removed the request for review from tsedmik June 29, 2021 14:48
@djelinek
Copy link
Contributor

testPR

3 similar comments
@djelinek
Copy link
Contributor

testPR

@djelinek
Copy link
Contributor

testPR

@djelinek
Copy link
Contributor

testPR

@djelinek djelinek merged commit f7566ee into jbosstools:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhein lhein lhein approved these changes

@apupier apupier apupier approved these changes

@djelinek djelinek djelinek approved these changes

Assignees
No one assigned
Labels
READY FOR MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pospisilf @djelinek @lhein @apupier