Fusetools 3497 fix jmx nodes with fuse 7.9 #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
detect JMX connection
- done the required part to support the default case starting from Fuse
7.9
- not all cases covered (several ${env in the same property, ${prop)but
enough for default case and still more than before.
- seems cannot reuse directly Karaf code to interpolate properties
https://github.com/apache/karaf/blob/5144a1eba5687dab0f016a9bf95e58e6687a26ad/client/src/main/java/org/apache/karaf/client/ClientConfig.java#L236
as the system.properties is expected to be preloaded and o not taking
care of default values provided at this place but got inspiration from
this code
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
lhein
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve support of reading Karaf properties file to
detect JMX connection
7.9
enough for default case and still more than before.
https://github.com/apache/karaf/blob/5144a1eba5687dab0f016a9bf95e58e6687a26ad/client/src/main/java/org/apache/karaf/client/ClientConfig.java#L236
as the system.properties is expected to be preloaded and o not taking
care of default values provided at this place but got inspiration from
this code
unit test provided covering 7.8 (and surely all 6.x and 7.x) and 7.9. I' think that there is a test on QE side testing the jmx connection when new Fuse Karaf is provided. To be checked. if not the case, I think it remains more interesting to have the test at this level. it will allow to better to detect potential issues than the unit tests as it can be affected by a lot of peripheral parts. Issue for new UI test https://issues.redhat.com/browse/FUSETOOLS-3499