Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUSETOOLS-3401: UI Tests - Fix broken 'fuse-openshift' Jenkins job #1732

Merged
merged 1 commit into from Nov 10, 2021

Conversation

pospisilf
Copy link
Contributor

Signed-off-by: Filip Pospisil fpospisi@redhat.com

Pull Request Checklist

After this checklist is all checked or PR provides explanations for possible pass-through, please put the label "Ready for review" on the PR.

General

  • Did you use the Jira Issue number in the commit comments?
  • Did you set meaningful commit comments on each commit?
  • Did you sign off all commits for this PR? (git commit -s -m "jira issue number - your commit comment")

Functional

  • Did the CI job report a successful build?
  • Is the non-happy path working, too?

Maintainability

  • Are all Sonar reported issues fixed or can they be ignored?
  • Is there no duplicated code?
  • Are method-/class-/variable-names meaningful?

Tests

  • Are there unit-tests?
  • Are there integration tests (or at least a jira to tackle these)?
  • Do we need a new UI test?

Legal

  • Have you used the correct file header copyright comment?
  • Have you used the correct year in the headers of new files?

@pospisilf pospisilf requested a review from a team as a code owner November 1, 2021 22:22
@pospisilf pospisilf added DRAFT and removed DRAFT labels Nov 1, 2021
@pospisilf pospisilf changed the title DRAFT: FUSETOOLS-3401: UI Tests - Fix broken 'fuse-openshift' Jenkins job FUSETOOLS-3401: UI Tests - Fix broken 'fuse-openshift' Jenkins job Nov 1, 2021
@pospisilf
Copy link
Contributor Author

#1728 must be merged first!

djelinek
djelinek previously approved these changes Nov 4, 2021
Signed-off-by: Filip Pospisil <fpospisi@redhat.com>
@djelinek
Copy link
Contributor

djelinek commented Nov 8, 2021

testPR

@djelinek djelinek merged commit 7476fa8 into master Nov 10, 2021
@pospisilf pospisilf deleted the FUSETOOLS-3401-2 branch November 20, 2021 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants