JBIDE-21025: hibernate querying nor content assist is broken #83
Conversation
| } | ||
| } | ||
|
|
||
| } catch (Throwable t) { |
There was a problem hiding this comment.
Can we check if DB is correctly configured to avoid that NPE instead of catching Throwable?
There was a problem hiding this comment.
Maybe i'm wrong but i suppose it is possible to do something like a "Test Connection" button in a org.eclipse.datatools.connectivity.ui.wizards.ConnectionProfileDetailsPage. I mean get connectionProfile by some of the ProfileManager.getInstance().getProfileBy methods of the datatools project. And then run org.eclipse.datatools.connectivity.ui.PingJob and join it
There was a problem hiding this comment.
Created one more PR with pinging the database.
There was a problem hiding this comment.
It is never okey to catch Throwable - you will by that catch fatal errors like outofmemory or worse.
There was a problem hiding this comment.
True, but as I already explained to Alexey, this has been there since ages and it is not the cause of this particular problem. Removing the Throwable has a lot more implications and needs to be done with care as it might affect other pieces of the Eclipse Hibernate Tools project. It's something that shouldn't be done in this branch IMO.
There was a problem hiding this comment.
okey - did not notice it was old code. then yes, seperate issue/PR for it
No description provided.