Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBIDE-16269 using parameterize the URL from which SWTBot is installed using -DSWTBOT_UPDATE_SITE=http://... >> master #13

Merged
merged 1 commit into from Dec 9, 2013
Merged

JBIDE-16269 using parameterize the URL from which SWTBot is installed using -DSWTBOT_UPDATE_SITE=http://... >> master #13

merged 1 commit into from Dec 9, 2013

Conversation

nickboldt
Copy link
Member

No description provided.

@nickboldt nickboldt restored the JBIDE-16269 branch December 7, 2013 19:40
@mickaelistria
Copy link
Contributor

What happens in case property is not set? There should be a default value.

@nickboldt
Copy link
Member Author

Default value on line 208: https://github.com/jbosstools/jbosstools-install-grinder/pull/13/files#diff-fb3c0f0629a72d5a583b325f2f070b0aR208

@mickaelistria
Copy link
Contributor

Ok, I missed this. +1 then.

@mickaelistria mickaelistria merged commit 95d3c69 into jbosstools:master Dec 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickboldt @mickaelistria