JBIDE-22852 Add check for errors in log when cancelling New Project wizard in OpenNewApplicationWizardWithNoProjectTest #1559
Conversation
|
Can one of the admins verify this patch? |
| new ContextMenu(OpenShiftLabel.ContextMenu.NEW_OS3_APPLICATION).select();; | ||
|
|
||
| try { | ||
| new WaitWhile(new ShellWithTextIsAvailable(OpenShiftLabel.Shell.CREATE_OS_PROJECT), TimePeriod.LONG); |
There was a problem hiding this comment.
there should be WaitUntil, because as it is written now, it would fail every time if Create Project wizard is opened on top of New App wizard.
There was a problem hiding this comment.
That sounds quite reasonable, but since I copied it from another test method testOpenNewApplicationWizardFromOpenShiftExplorerWithNoProjects(), can it mean that it is a coding error there?
I have replaced WaitWhile with WaitUntil in both places.
|
@scabanovich added inline comments. Please fix them and then ask @psrna for merging commit. |
…izard in OpenNewApplicationWizardWithNoProjectTest
scabanovich
force-pushed
the
jbide-22852
branch
from
1c5902c
to
344541c
Compare
|
@scabanovich good catch with wait condition. It's evaluated so fast even the shell has not been yet opened and thus it passed. Now it looks good to me. |
|
test this |
No description provided.