JBIDE-23285 Unify runtimes download #1704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now this PR only modifies AS tests and runtime tests a little bit - I need to talk to Radim about runtime tests. Others can be modified later or also as part of this PR, we can discuss that. |
mmalina
force-pushed
the
JBIDE-23285-unify-download
branch
from
bfe40ce
to
0fa7bd4
Compare
rawagner
reviewed
Dec 16, 2016
| @@ -213,6 +252,11 @@ | |||
| <skip>${skipTests}</skip> | |||
| </configuration> | |||
| </plugin> | |||
| <!-- <plugin> | |||
There was a problem hiding this comment.
we can remove this commented plugin, right ?
There was a problem hiding this comment.
you're right, I somehow missed this. fixed.
The property files will be handled in tests/pom.xml directly. projects-download.properties will be loaded automatically and you can use all the properties in your pom. products-download.properties is provided as an empty file. If your tests require products, either replace this file with your own, or specify your own file when calling maven: -Dproduct-download-properties-file=MY_FILE
mmalina
force-pushed
the
JBIDE-23285-unify-download
branch
from
0fa7bd4
to
7016b51
Compare
|
I think this PR doesn't necessarily work with teh PR's i've proposed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property files will be handled in tests/pom.xml directly.
projects-download.properties will be loaded automatically and
you can use all the properties in your pom.
products-download.properties is provided as an empty file.
If your tests require products, either replace this file with your
own, or specify your own file when calling maven:
-Dproduct-download-properties-file=MY_FILE