JBIDE-25520 #1907
JBIDE-25520 #1907
Conversation
| -DquickstartsURLJavaEE=${quickstartsURLJavaEE} - URL for JavaEE7 Quickstarts | ||
| -DexamplesFolderJavaEE=${examplesFolderJavaEE} - examples folder of JavaEE7 Quickstarts | ||
|
|
||
| All: | ||
| -DdeployOnServer=true - if false, only import is performed, if true, project is imported (Default value true) | ||
|
|
||
|
|
||
|
|
||
|
|
||
| Note: make sure to backup ~/.m2/settings.xml |
There was a problem hiding this comment.
While using -Dmaven.settings.path=~/.m2/settings.xml and test is killed requirement changing settings.xml may not revert changes.
There was a problem hiding this comment.
This should be also in readme.
| G.e.: | ||
|
|
||
| ``` | ||
| mvn clean verify -DskipTests=false -Dusage_reporting_enabled=false -Dswt.bot.test.record.screencast=true -Dorg.eclipse.swtbot.screenshots.dir=./target/screenshots -Dcom.atlassian.connector.eclipse.monitor.usage.first.time=false -Dcom.atlassian.connector.eclipse.monitor.usage.enabled=false -Dmaven.settings.path=~/.m2/settings.xml -Drd.config=./target/classes/servers/eap-7.json -DdeployOnServer=false -Dreddeer.close.shells=true -Dreddeer.close.welcome.screen=true -Dreddeer.disable.maven.download.repo.index.on.startup=true -DquickstartsURLEAP=http://download.eng.brq.redhat.com/released/JBEAP-7/7.1.0/jboss-eap-7.1.0-quickstarts.zip -DexamplesFolderEAP=jboss-eap-7.1.0.GA-quickstarts -Djbosstools.test.jboss-eap-7.x.url=http://download.eng.brq.redhat.com/released/JBEAP-7/7.1.0/jboss-eap-7.1.0.zip -PEAP7 -DspecificQuickstarts=helloworld-jms |
There was a problem hiding this comment.
Do we really need all of these parameters? Quite a lot of these parameters have default values in this pom or in parent poms.
There was a problem hiding this comment.
There were missing parameters for devstudios Debug/Run Configurations
There was a problem hiding this comment.
In this case you can also commit launch configurations(e.g. https://github.com/jbosstools/jbosstools-integration-tests/tree/master/tests/org.jboss.tools.forge.ui.bot.test/launchers) and leave here only necessary parameters. You are not specifying that you need all of these parameters when running from CLI or eclipse.
I would also suggest adding command example for JavaEE7.
|
Updated README.md and added Launcher configuration |
| - for local testing it might be convenient to use -Dreddeer.close.welcome.screen=true | ||
| - you can run test for single or several quickstarts by using -DspecificQuickstarts=temperature-converter,xml-dom4j,helloworld-ws,websocket-hello,helloworld | ||
| - you can also use -DexamplesLocation=<pathToQuickstartsDir> that overrides -DexamplesFolder<JavaEE|EAP|WildFly> you may use something like -DexamplesLocation=./target/<quickstartsDir> | ||
| - you can also force maven to download devstudio using -Pdownload-devstudio |
There was a problem hiding this comment.
@vprusa I would also add note about BLACKLIST_ERRORS_REGEXES_FILE, and maybe also mention Jiras, why these quickstarts have been blacklisted.
Otherwise it looks good.
Moved checkstyle plugin req to global build Ignore more documented errors Added Devstudio Launchers Signed-off-by: vprusa <vprusa@redhat.com>
Documented errors:
Checkstyle execution... - is automatically resolved, but sometimes it hangs.
spring-petclinic - relates to JS support and split JS files
jaxws-retail - missing files needs to be generated from wsdl first.
Referenced file contains errors.. & nvalid content was found - relates to duplicate entries for xml definition files, bz & duplicates
Related job run
Signed-off-by: vprusa vprusa@redhat.com