JBIDE-24963-2 - Create CDI 2.0 integration tests - step 2 #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odockal
requested changes
Jun 4, 2019
|
|
||
| @Before | ||
| public void changeDiscoveryMode(){ | ||
| validationProvider = new BeansXmlValidationProviderCDI11(); |
There was a problem hiding this comment.
Are you sure that this class contains all that is needed/changed/new in cdi 2.0 specs? Aren't they any different?
There was a problem hiding this comment.
@zcervink Do you dare to address the required changes?
|
|
||
| @Before | ||
| public void setValidationProvider(){ | ||
| validationProvider = new BeansXmlValidationProviderCDI11(); |
There was a problem hiding this comment.
Same question as above. Probably same answer ;)
zcervink
force-pushed
the
JBIDE-24963-2
branch
2 times, most recently
from
f5b8253
to
ea58be8
Compare
|
testPR |
odockal
requested changes
Jul 8, 2019
|
|
||
| @Before | ||
| public void changeDiscoveryMode(){ | ||
| validationProvider = new BeansXmlValidationProviderCDI11(); |
There was a problem hiding this comment.
@zcervink Do you dare to address the required changes?
|
Good. Let's wait for the build to finish. |
|
@zcervink Tests are still failing. |
|
Current Jenkins build: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/cdi20.itests/58/ |
odockal
approved these changes
Jul 15, 2019
|
+1. @jkopriva Merge this please. |
BeansXMLBeansEditorTestCDI20.class BeansXMLValidationTestCDI20.class BeansXMLValidationQuickFixTestCDI20.class Signed-off-by: Zbynek Cervinka <zcervink@redhat.com>
|
Merging, we should create JIRA for duplicated strings and fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JBIDE-24963-2 - Create CDI 2.0 integration tests - step 2; following testclasses are added:
- BeansXMLBeansEditorTestCDI20.class
- BeansXMLValidationTestCDI20.class
- BeansXMLValidationQuickFixTestCDI20.class
Signed-off-by: Zbynek Cervinka zcervink@redhat.com
@odockal please review
Jira: https://issues.jboss.org/browse/JBIDE-24963
Jenkins: https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/cdi20.itests/16/